list machine objects #367
Closed
list machine objects #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
petersutter
requested changes
Jan 11, 2024
There was a problem hiding this comment.
- it's not necessary to hold additional info on the options struct - get rid of it and move the code in the complete function to the place where the machines are fetched
- fetch the nodes and just try to fetch the machines (ignore forbidden errors and just log all other erros like it was done in the other PR) and pass both lists to the NewConnectInformation and handle it there instead of creating fake corev1.Node structs
gardener-robot-ci-2
added
reviewed/ok-to-test
…ll not be displayed.
tedteng
force-pushed
the
list_machine_name
branch
from
aced38e
to
043d835
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
|
Hi @tedteng, thank you for your effort on the pull request. I see that it would require some extensive revisions. To maintain efficiency and to help guide the process, I've initiated a new PR (#368) that incorporates some of your ideas. I suggest we focus our efforts there. You may want to close this one. Please don't hesitate to review the new PR and let me know your thoughts. Your contributions are valuable and appreciated. |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #361
Special notes for your reviewer:
Release note: